Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/87#discussion_r58418513
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java
---
@@ -831,11 +814,16 @@ public void send(TabletServerMutations<Mutation> tsm)
throws AccumuloServerExcep
try {
long count = 0;
- for (List<Mutation> list : mutationBatch.values()) {
- count += list.size();
+
+ Set<Text> tableIds = new TreeSet<Text>();
+ for (Map.Entry<KeyExtent,List<Mutation>> entry :
mutationBatch.entrySet()) {
+ count += entry.getValue().size();
+ tableIds.add(entry.getKey().getTableId());
}
- String msg = "sending " + String.format("%,d", count) + "
mutations to " + String.format("%,d", mutationBatch.size()) + " tablets at " +
location;
- Thread.currentThread().setName(msg);
+ StringBuilder msg = new StringBuilder();
--- End diff --
If you're going to build up `msg` inside of the for loop, I think it makes
sense to use the StringBuilder. Just in the current state, it didn't look like
there was any benefit to the use of a StringBuilder (so it just came across as
an unnecessary change).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
