Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/90#discussion_r59598295
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/FileOperations.java ---
@@ -55,23 +56,24 @@ public static FileOperations getInstance() {
*/
public abstract FileSKVIterator openReader(String file, Range range,
Set<ByteSequence> columnFamilies, boolean inclusive, FileSystem fs,
Configuration conf,
- AccumuloConfiguration tableConf) throws IOException;
+ RateLimiter readLimiter, AccumuloConfiguration tableConf) throws
IOException;
public abstract FileSKVIterator openReader(String file, Range range,
Set<ByteSequence> columnFamilies, boolean inclusive, FileSystem fs,
Configuration conf,
- AccumuloConfiguration tableConf, BlockCache dataCache, BlockCache
indexCache) throws IOException;
+ RateLimiter readLimiter, AccumuloConfiguration tableConf, BlockCache
dataCache, BlockCache indexCache) throws IOException;
/**
* Open a reader that fully support seeking and also enable any
optimizations related to seeking, like bloom filters.
*
*/
- public abstract FileSKVIterator openReader(String file, boolean
seekToBeginning, FileSystem fs, Configuration conf, AccumuloConfiguration
acuconf)
- throws IOException;
+ public abstract FileSKVIterator openReader(String file, boolean
seekToBeginning, FileSystem fs, Configuration conf, RateLimiter readLimiter,
--- End diff --
> Not sure exactly what you mean, but what I meant was along the lines of
creating a "FileOptions" (or similar) object to pass around instead of the
AccumuloConfiguration object which is narrowly applicable to the context of
those utility methods (context: operations on files?), and which is composed of
the relevant configs from wherever they are sourced.
Something like:
```
T impl = acuConf.getImpl(Property.MY_FACTORY_IMPLEMENTATION);
```
Concretely:
```
RATE_LIMITER_FACTORY("tserver.rate.limiter.factory",
SharedRateLimiterFactory.class, PropertyType.IMPL, "...")
```
```
RateLimiterFactory factory = acuConf.getImpl(Property.RATE_LIMITER_FACTORY);
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
