Github user ShawnWalker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/95#discussion_r60623785
--- Diff:
test/src/main/java/org/apache/accumulo/test/proxy/SimpleProxyBase.java ---
@@ -2077,7 +2077,8 @@ public void bulkImport() throws Exception {
// Write an RFile
String filename = dir + "/bulk/import/rfile.rf";
- FileSKVWriter writer =
FileOperations.getInstance().openWriter(filename, fs, fs.getConf(), null,
DefaultConfiguration.getInstance());
+ FileSKVWriter writer =
FileOperations.getInstance().openWriter().ofFile(filename, fs, fs.getConf())
+
.withTableConfiguration(DefaultConfiguration.getInstance()).execute();
--- End diff --
Within the Accumulo source, the only time that the "default" configuration
is the right answer is in tests. Having `FileAccessOperations` provide the
default configuration might make writing some tests a tad easier, but at the
cost of making it easier to write buggy functional code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
