Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/110#discussion_r66142161
  
    --- Diff: assemble/bin/config.sh ---
    @@ -118,6 +118,20 @@ else
       export NUMA_CMD=""
     fi
     
    +# NUMA sanity checks
    +if [[ -z $NUM_TSERVERS ]]; then
    +   echo "NUM_TSERVERS is missing in accumulo-env.sh, please check your 
configuration."
    +   exit 1
    +fi
    +if [[ $NUM_TSERVERS -eq 1 && -n $TSERVER_NUMA_OPTIONS ]]; then
    +   echo "TSERVER_NUMA_OPTIONS declared when NUM_TSERVERS is 1, use 
ACCUMULO_NUMACTL_OPTIONS instead"
    +   exit 1
    +fi
    +if [[ $NUM_TSERVERS -gt 1 && ${#TSERVER_NUMA_OPTIONS[*]} -ne $NUM_TSERVERS 
]]; then
    --- End diff --
    
    Could make this sanity check 
    ```bash
    if [[ $NUM_TSERVERS -gt 1 && ${#TSERVER_NUMA_OPTIONS[*]} -ne $NUM_TSERVERS 
&& ${#TSERVER_NUMA_OPTIONS[*]} -gt 0]];
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to