Superb. I half wondered what was going on and why I was emailed in the
first place.
Let's give them the benefit of the doubt that they're going to actually
respond and then close (assuming they do in fact never respond).
Dylan Hutchison wrote:
What a funny series of PRs to see this morning. As you probably figured out
Josh, the DevFactory folks run scripts that download the code of
open-source repos, run them with lots of lint, and create PRs with
generated fixes.
No human created these PRs; no human will respond to your comments. It is
up to us to accept real issues and reject false positives (e.g. changes to
thrift classes).
On Jun 21, 2016 10:55 AM, "Josh Elser"<[email protected]> wrote:
Again, please use the mailing list [email protected] for all future
Apache Accumulo related correspondence.
Thanks.
George Kankava wrote:
Hi Josh,
I have created several PRs for your project.
Hope they will be useful and you will like them.
Please feel free to chose which one of them you would like to merge
and let me know if there are any issues I will be happy to fix.
Regards,
George
On Sun, Jun 19, 2016 at 9:57 PM, Josh Elser<[email protected]
<mailto:[email protected]>> wrote:
Hi George,
We would be happy for any contributions you'd like to make to
Accumulo. We do try to keep up on what Findbugs reports already but
I'm sure some slip through.
I've cc'ed the developer list. Please use that for future
correspondence.
Thanks!
- Josh
On Jun 19, 2016 12:51 PM, "George Kankava"
<[email protected]
<mailto:[email protected]>> wrote:
Hello,
I'd like to send you some pull requests to improve the
maintainability of accumulo.
My company - DevFactory - is sponsoring me to identify and fix
code quality issues and improve unit test coverage in open
source projects. DevFactory is obsessed with code quality and is
providing its commercially available code quality improvement
service for free to qualified open-source projects.
If you are interested, please let me know and we will add it to
our pipeline. Our first step will be to utilize tools like PMD,
FindBugs and Sonar to identify the most important issues to fix.
Once we fix them, we'll follow up with some pull requests.
Thanks,
George Kankava
