Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/126#discussion_r71157971
--- Diff: shell/src/main/java/org/apache/accumulo/shell/Shell.java ---
@@ -242,9 +242,8 @@
}
}
- public Shell() throws IOException {
- this(new ConsoleReader());
- }
+ // no arg constructor should do minimal work since its used in Main
ServiceLoader
+ public Shell() throws IOException {}
--- End diff --
Can remove the `throws IOException` as it won't affect callers at all. They
were already expecting the IOException -- if we don't throw that anymore,
that's fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
