Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/131#discussion_r72096789
--- Diff: assemble/src/main/scripts/generate-download-script.sh ---
@@ -0,0 +1,56 @@
+#! /usr/bin/env bash
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# This script will generate a DEPENDENCIES listing of packaged dependencies
+
+in=target/dependencies.raw.txt
+out=target/download-dependencies
+
+cat >"$out" <<'EOF'
+#! /usr/bin/env bash
+# This script downloads the following jars, identified by their maven
+# coordinates, using the maven-dependency-plugin.
+#
+# DISCLAIMER: This is only one possible way to download a set of
dependencies
--- End diff --
I am trying understand what the goal is with these changes. Are the
following the goals?
1. Make it easier for Accumulo developers to maintain accurate NOTICE and
LICENSE files.
2. Communicate to users that dependencies are provided as an example that
worked with a single version of Hadoop at release time. Explain that users may
need different dependencies depending on their environment, later bug fix
versions of dependencies, etc.
Given these two goals, the script clearly accomplishes the first. However
I think the 2nd goal could be accomplished in other ways. For example a Readme
in the Accumulo lib directory communicating information about dependencies
would accomplish this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
