Github user phrocker commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/134#discussion_r72662901
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BoundedRangeFileInputStream.java
---
@@ -62,12 +62,15 @@ public BoundedRangeFileInputStream(FSDataInputStream
in, long offset, long lengt
@Override
public int available() throws IOException {
- int avail = in.available();
- if (pos + avail > end) {
- avail = (int) (end - pos);
- }
+ final FSDataInputStream inLocal = in;
+ synchronized (inLocal) {
+ int avail = inLocal.available();
--- End diff --
Why? DFS won't even do that for you. they'll take the file length - pos,
why couldn't the same liberty be used in this case? Accumulo is inherently
coupled with DFS why even attempt to promulgate the idea that the InputStream
API should be adhered?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
