I didn't consider it something to hold things up over either... just a "would be nice". I'd have voted a +1. I voted +0 mainly for the bin/accumulo breakage, while we were still investigating.
On Thu, Sep 1, 2016 at 3:26 PM Josh Elser <[email protected]> wrote: > I will just say that I didn't expect to have this put in 1.8.0 when I > was working on it. Not that it changes much anything, just thought I > would mention that my intentions were specifically to _not_ hold up 1.8.0. > > Christopher wrote: > > +0 > > > > Verified all ITs (including performance tests) pass, except for > occasional > > timeouts and the occasional "Connection reset by peer" issues with > > Replication drain. > > Verified all SIGs and hashes. > > Verified branch matches source tarball and jars match what's in bin > tarball. > > Verified no unexpected new artifacts included in deploy. > > Verified sources/javadoc jar existences. > > > > I'd like to get ACCUMULO-4423 and ACCUMULO-4443 in, so that's available > in > > the .0 TESTING docs for users, but it's not a blocker. > > There's a possibility that something is broke with "bin/accumulo > > rfile-info", which I need to investigate. Also not a blocker, but would > be > > unfortunate if that didn't work out of the box. > > > > On Thu, Sep 1, 2016 at 2:31 PM Michael Wall<[email protected]> wrote: > > > >> I know they are late, but draft release notes are up at > >> https://accumulo.apache.org/release_notes/1.8.0. If this vote passes, > >> I'll > >> resolve all concerns about the release notes before finalizing the > release. > >> > >> Mike > >> > >> On Thu, Sep 1, 2016 at 1:30 PM, Christopher<[email protected]> > wrote: > >> > >>> I've done some initial checks and things basically look good. However, > >>> there are still a few tests failing due to timeouts and related > >>> platform-variant expectations. > >>> I also noticed that because of ACCUMULO-3929, many tests have been > >>> overlooked entirely (at least by me) for the entire development period > >>> leading up to this release, because those tests are not run by default. > >>> > >>> I would like to do a quick run of these skipped and failed tests, to > see > >> if > >>> they pass, before I vote. > >>> > >>> On Thu, Sep 1, 2016 at 1:03 PM Michael Wall<[email protected]> wrote: > >>> > >>>> Continuous ingest with agitation on 8 d2.xlarge nodes running tservers > >>> and > >>>> 3 m3.xlarge master nodes for ~16 hours was successful. > >>>> > >>>> Entries for the ci table in the monitor = 15.91B > >>>> > >>>> Counters from run verify MR > >>>> REFERENCED 15895094416 > >>>> UNREFERENCED 2000635 > >>>> > >>>> Working on the release notes now. Less than 2 hours left on the vote. > >>>> > >>>> Mike > >>>> > >>>> > >>>> On Thu, Sep 1, 2016 at 11:28 AM, Josh Elser<[email protected]> > wrote: > >>>> > >>>>> +1 (binding) > >>>>> > >>>>> * xsum/sigs match > >>>>> * No unexpected binaries in source-release > >>>>> * japi compat report looks fine (see note about IteratorAdapter > >> below) > >>>>> * Verified diffs over 1.8.0-rc2 (they are as expected) > >>>>> * CI on rc2 was good (see rc2 vote for details, did not retest given > >>>>> previous point) > >>>>> * Ran all unit and integration tests > >>>>> * Stood up a single node instance locally with the bin-tarball > >>>>> > >>>>> There are some incompatibilities with a Mock class (in public API) > >>>>> IteratorAdapter which extends a non-public API class > >>>>> (o.a.a.c.i.IteratorAdapter). I'm not worried about this because Mock > >>> has > >>>>> been deprecated for a bit. > >>>>> > >>>>> Michael Wall wrote: > >>>>> > >>>>>> Accumulo Developers, > >>>>>> > >>>>>> Please consider the following candidate for Accumulo 1.8.0. > >>>>>> > >>>>>> Git Commit: > >>>>>> ad281753325b4d9d593aa02ba11a1041ded5296d > >>>>>> Branch: > >>>>>> 1.8.0-rc3 > >>>>>> > >>>>>> If this vote passes, a gpg-signed tag will be created using: > >>>>>> git tag -f -m 'Apache Accumulo 1.8.0' -s rel/1.8.0 > >>>>>> ad281753325b4d9d593aa02ba11a1041ded5296d > >>>>>> > >>>>>> Staging repo: > >>>>>> > >>>> https://repository.apache.org/content/repositories/ > >>> orgapacheaccumulo-1056 > >>>>>> Source (official release artifact): > >>>>>> https://repository.apache.org/content/repositories/orgapache > >>>>>> accumulo-1056/org/apache/accumulo/accumulo/1.8.0/ > >>>>>> accumulo-1.8.0-src.tar.gz > >>>>>> Binary: > >>>>>> https://repository.apache.org/content/repositories/orgapache > >>>>>> accumulo-1056/org/apache/accumulo/accumulo/1.8.0/ > >>>>>> accumulo-1.8.0-bin.tar.gz > >>>>>> (Append ".sha1", ".md5", or ".asc" to download the signature/hash > >> for > >>> a > >>>>>> given artifact.) > >>>>>> > >>>>>> All artifacts were built and staged with: > >>>>>> mvn release:prepare&& mvn release:perform > >>>>>> > >>>>>> Signing keys are available at https://www.apache.org/dist/ > >>> accumulo/KEYS > >>>>>> (Expected fingerprint: 3E38C02F85303BAB37EE58C2F899DBF0B8C3D406) > >>>>>> > >>>>>> Release notes (in progress) can be found at: > >>>>>> https://accumulo.apache.org/release_notes/1.8.0 > >>>>>> > >>>>>> Please vote one of: > >>>>>> [ ] +1 - I have verified and accept... > >>>>>> [ ] +0 - I have reservations, but not strong enough to vote > >> against... > >>>>>> [ ] -1 - Because..., I do not accept... > >>>>>> ... these artifacts as the 1.8.0 release of Apache Accumulo. > >>>>>> > >>>>>> This vote will end on Thu Sep 1 19:00:00 UTC 2016 > >>>>>> (Thu Sep 1 15:00:00 EDT 2016 / Thu Sep 1 12:00:00 PDT 2016) > >>>>>> > >>>>>> Thanks! > >>>>>> > >>>>>> P.S. Hint: download the whole staging repo with > >>>>>> wget -erobots=off -r -l inf -np -nH \ > >>>>>> > >>>>>> https://repository.apache.org/content/repositories/orgapache > >>>>>> accumulo-1056/ > >>>>>> # note the trailing slash is needed > >>>>>> > >>>>>> > > >
