Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/154#discussion_r79496803
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/cli/ClientOpts.java 
---
    @@ -92,6 +94,20 @@ public Password(String dfault) {
         public String toString() {
           return new String(value, UTF_8);
         }
    +
    +    /**
    +     * Prompts user for a password
    +     *
    +     * @return user entered Password object, null if no console exists
    +     */
    +    public static Password promptUser() throws IOException {
    +      if (System.console() == null) {
    +        return null;
    --- End diff --
    
    I'm thinking that throwing an exception here would be more clear. This 
method cannot properly function as the caller expected, so they should get a 
clear exception in this case (not just a null return value).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to