Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/159#discussion_r84780608
  
    --- Diff: 
server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java ---
    @@ -253,6 +257,9 @@ public static double 
estimatePercentageLTE(VolumeManager fs, AccumuloConfigurati
           return (numLte + 1) / (double) (numKeys + 2);
     
         } finally {
    +      if (mmfi != null) {
    --- End diff --
    
    Would be better to move these lines after `cleanupIndexOp` ... or wrap with 
try+catch+log so that cleanupIndexOp can still run


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to