Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/159#discussion_r88543835
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/SortedKeyValueIterator.java
---
@@ -147,4 +147,13 @@
* if not supported.
*/
SortedKeyValueIterator<K,V> deepCopy(IteratorEnvironment env);
+
+ /**
+ * Closes the Iterator. This should be overridden by the implementing
class that has access to <tt>SortedKeyValueIterator source</tt> provided in the
--- End diff --
Thanks for the rewording, Mike. I'm still left with an ambiguous feeling
after reading it.
* Would recommend not using words like "Typically". If an SKVI's `source`
should be closed in the `close()` method, be explicit. This also makes me
wonder, are these semantics `SHOULD` or `MUST`? What happens to an SKVI I have
which doesn't implement close?
* Exceptional cases are still not covered. Should implementations of
`close()` eat exceptions or propagate them as RuntimeExceptions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
