GitHub user milleruntime opened a pull request:
https://github.com/apache/accumulo/pull/188
Accumulo 4525: Replace meaningless method names
While trying to learn the internals of Accumulo, I found a lot of the
method names in Test to be confusing. I think Tests are an under utilized
learning tool for newcomers. Many method names in Test were clearly chosen for
brevity rather than clarity which I think is a bad habit that doesn't help new
Accumulo developers.
This PR is for 2.0 (branch with the most changes). I have similar changes
for 1.7 and 1.8 branches. Tests should be the same functionally but I wanted
other devs to see the changes and get their opinions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/milleruntime/accumulo ACCUMULO-4525_2.0
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/accumulo/pull/188.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #188
----
commit 8a35b6dd48668449919a172afb96a9851ce211a0
Author: Mike Miller <[email protected]>
Date: 2016-11-17T18:55:03Z
ACCUMULO-4522: cleanup of unsed param in FileUtil
commit 43b740bc77fd51e428328a2f1b4fef1c32c202d2
Author: Mike Miller <[email protected]>
Date: 2016-11-17T18:58:29Z
Merge branch '1.7' into 1.8
commit a4a453986407132f2798b0e9c22fc26509f8d75e
Author: Mike Miller <[email protected]>
Date: 2016-11-22T15:59:44Z
ACCUMULO-4525: replace meaningless method names
commit cd70d7815afad9ae7d0f78c5fa916833b274690b
Author: Mike Miller <[email protected]>
Date: 2016-11-22T19:58:58Z
Merge branch '1.7' into 1.8
Conflicts:
core/src/test/java/org/apache/accumulo/core/data/RangeTest.java
core/src/test/java/org/apache/accumulo/core/file/rfile/RFileTest.java
core/src/test/java/org/apache/accumulo/core/iterators/system/MultiIteratorTest.java
commit 4ac458e857e168f410b03cc986772f4e069e33be
Author: Mike Miller <[email protected]>
Date: 2016-11-22T20:03:57Z
Merge branch '1.8'
commit fcde1d93aeab12fb26c2f38b225b3d470fe1d44c
Author: Mike Miller <[email protected]>
Date: 2016-11-23T13:13:53Z
ACCUMULO-4525: replace more meaningless method names
commit f5e9ee20af05e4fa3c22cbd6de436e5ab8fb7a32
Author: Mike Miller <[email protected]>
Date: 2016-11-23T13:42:11Z
Merge branch '1.8'
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
