Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/193#discussion_r94479375
  
    --- Diff: 
server/base/src/main/java/org/apache/accumulo/server/master/balancer/HostRegexTableLoadBalancer.java
 ---
    @@ -254,7 +255,7 @@ public int getMaxConcurrentMigrations() {
       }
     
       @Override
    -  public void init(ServerConfiguration conf) {
    +  public void init(ServerConfigurationFactory conf) {
    --- End diff --
    
    Ah, sorry. Refreshing myself.
    
    IMO, we need to fix the type hierarchy mess that is TableLoadBalancer. I 
won't push it on to you to fix, but can you please create a JIRA issue to track 
removing this duplicity and to come up with a plan for compatibility (an 
interface that lives in public API)? It'd be awesome if you'd want to do it as 
well :)
    
    I'm ok with this getting merged in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to