Github user joshelser commented on the issue:

    https://github.com/apache/accumulo/pull/198
  
    > It would be interesting to see and try to write a test for it. I would 
appreciate if you point me in the right direction.
    
    You've had a little bit of experience here, seeing what Thrift generates 
and how to implement the server-side interface.
    
    At a high level, think about the Accumulo Java 'Public API' is a wrapper 
around the Thrift RPCs. Client-side, we also have the Thrift generated code. 
Typically, the public API call would call either `MasterClient.execute(..)`, 
`ServerClient.execute(..)`, or `ThriftUtil.getTServerClient(..)`. These calls 
are for Master RPCs, RPC to any TabletServer, or RPC to a specific 
TabletServer, specifically.
    
    I would not worry about doing a low-level test case, instead, build some 
public API method and then write a test around that new method. I think adding 
a method to `InstanceOperations` makes the most sense here.
    
    If we decide that we don't want to make a new public API call for this, 
using `MasterClient.execute` to invoke the `getMasterStats(..)` method. 
https://github.com/apache/accumulo/blob/e900e67425d950bd4c0c5288a6270d7b362ac458/core/src/main/java/org/apache/accumulo/core/client/impl/InstanceOperationsImpl.java#L69-L74
 is an example of how to invoke this method. Hopefully this will be very 
straightforward to do with any of the existing test classes that extend 
AccumuloClusterIT.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to