Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo-testing/pull/3#discussion_r98796795
--- Diff: core/src/main/java/org/apache/accumulo/testing/core/TestEnv.java
---
@@ -96,15 +97,22 @@ public String getPid() {
}
public Configuration getHadoopConfiguration() {
- Configuration config = new Configuration();
- config.set("mapreduce.framework.name", "yarn");
- // Setting below are required due to bundled jar breaking default
- // config.
- // See
- //
http://stackoverflow.com/questions/17265002/hadoop-no-filesystem-for-scheme-file
- config.set("fs.hdfs.impl",
org.apache.hadoop.hdfs.DistributedFileSystem.class.getName());
- config.set("fs.file.impl",
org.apache.hadoop.fs.LocalFileSystem.class.getName());
- return config;
+ if (hadoopConfig == null) {
+ String hadoopPrefix = System.getenv("HADOOP_PREFIX");
+ if (hadoopPrefix == null || hadoopPrefix.isEmpty()) {
+ throw new IllegalArgumentException("HADOOP_PREFIX must be sent in
env");
+ }
+ hadoopConfig = new Configuration();
+ hadoopConfig.addResource(new Path(hadoopPrefix +
"/etc/hadoop/core-site.xml"));
--- End diff --
I think using the properties file is better. I don't think we should be
writing java code to depend on env variables, especially arbitrary script
conventions like `HADOOP_PREFIX`, which is very sensitive to Hadoop
packaging/deployment changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
