Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/221#discussion_r103020039
--- Diff: assemble/conf/log4j-monitor.properties ---
@@ -15,18 +15,18 @@
# Write out everything at the DEBUG level to the debug log
log4j.appender.A2=org.apache.log4j.RollingFileAppender
-log4j.appender.A2.File=${org.apache.accumulo.core.dir.log}/${org.apache.accumulo.core.application}_${org.apache.accumulo.core.ip.localhost.hostname}_fromprops.debug.log
+log4j.appender.A2.File=${accumulo.log.dir}/${accumulo.application}_${accumulo.local.hostname}.debug.log
log4j.appender.A2.MaxFileSize=100MB
-log4j.appender.A2.MaxBackupIndex=10
+log4j.appender.A2.MaxBackupIndex=5
log4j.appender.A2.Threshold=DEBUG
log4j.appender.A2.layout=org.apache.log4j.PatternLayout
log4j.appender.A2.layout.ConversionPattern=%d{ISO8601} [%-8c{2}] %-5p:
%X{application} %m%n
# Write out INFO and higher to the regular log
log4j.appender.A3=org.apache.log4j.RollingFileAppender
-log4j.appender.A3.File=${org.apache.accumulo.core.dir.log}/${org.apache.accumulo.core.application}_${org.apache.accumulo.core.ip.localhost.hostname}_fromprops.log
+log4j.appender.A3.File=${accumulo.log.dir}/${accumulo.application}_${accumulo.local.hostname}.log
--- End diff --
We definitely don't need both the "regular log" and "debug log" configured
in the default configuration file. We could shorten, and dramatically simplify
the default file by showing only one example, and indicating that appenders
could be used with different settings. This makes the file easier to understand
for users who wish to dive in and customize.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
