Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/228#discussion_r104527998
--- Diff:
minicluster/src/main/java/org/apache/accumulo/cluster/standalone/StandaloneAccumuloCluster.java
---
@@ -57,7 +57,7 @@
private Instance instance;
private ClientConfiguration clientConf;
- private String accumuloHome, clientAccumuloConfDir,
serverAccumuloConfDir, hadoopConfDir;
--- End diff --
There is a reason that both of these exist. Some tests do things that
require knowledge of the `instance.secret` (generally, configuration values
which are sensitive). Good deployment practices dictate that there is a
separation here -- as such, I don't see how this simplification is helpful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
