Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/228#discussion_r104997993
--- Diff:
minicluster/src/main/java/org/apache/accumulo/cluster/standalone/StandaloneClusterControl.java
---
@@ -149,9 +141,8 @@ String getJarFromClass(Class<?> clz) {
@Override
public void adminStopAll() throws IOException {
- File confDir = getConfDir();
- String master = getHosts(new File(confDir, "masters")).get(0);
- String[] cmd = new String[] {SUDO_CMD, "-u", user, ACCUMULO_CONF_DIR +
serverAccumuloConfDir, accumuloPath, Admin.class.getName(), "stopAll"};
+ String master = getHosts(MASTER_HOSTS_FILE).get(0);
+ String[] cmd = new String[] {SUDO_CMD, "-u", user, accumuloPath,
Admin.class.getName(), "stopAll"};
--- End diff --
> So you are not OK with the removal of ACCUMULO_CONF_DIR +
serverAccumuloConfDir
Oh, no, I'm not because you're still breaking things. I didn't realize you
didn't revert this change.
> Why do you need this?
See my previous comment: "StopAll is another utility which requires the
correct instance.secret.". It's the same reason I -1'ed the removal of the
accumuloServerConf property in the first place..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
