Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/232#discussion_r105184133
--- Diff:
shell/src/test/java/org/apache/accumulo/shell/ShellConfigTest.java ---
@@ -123,29 +118,21 @@ public void testTokenAndOptionAndPassword() throws
IOException {
@Test
public void testZooKeeperHostFallBackToSite() throws Exception {
ClientConfiguration clientConfig = new ClientConfiguration();
- Map<String,String> data = new HashMap<>();
- data.put(Property.INSTANCE_ZK_HOST.getKey(), "site_hostname");
- AccumuloConfiguration conf = new ConfigurationCopy(data);
- assertEquals("site_hostname", Shell.getZooKeepers(null, clientConfig));
+ assertFalse("Client config contains zk hosts",
clientConfig.containsKey(ClientConfiguration.ClientProperty.INSTANCE_ZK_HOST.getKey()));
+ assertEquals("localhost:2181", Shell.getZooKeepers(null,
clientConfig));
--- End diff --
So its testing that it falls back to the default?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
