Github user mikewalch commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/235#discussion_r107721029
  
    --- Diff: 
core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java ---
    @@ -209,13 +209,19 @@ static public long getMemoryInBytes(String str) {
             case 'B':
               multiplier = 0;
               break;
    +        case '%':
    --- End diff --
    
    I would rather not create another `PropertyType`. If the defaults are fixed 
memory, users probably won't switch to percentage.  If you are worried about 
certain properties, I could add some text to the description of those 
properties that fixed memory amounts should be used.  Even if we limit 
percentage, users can still misconfigure things by setting fixed memory values 
that are too high or low for that property.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to