Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/254#discussion_r113838502
  
    --- Diff: 
server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
 ---
    @@ -288,15 +295,36 @@ public String execute(ReplicationCoordinator.Client 
client) throws Exception {
                 }
               } else {
                 span = Trace.start("WAL replication");
    +
    +            ExecutorService executor = Executors.newFixedThreadPool(1);
    --- End diff --
    
    Any reason that we need to start an extra thread here?
    
    Guava has a `MoreExecutors` class with a special Executor that uses the 
same thread. Would that work here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to