Github user adamjshook commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/254#discussion_r114607540
  
    --- Diff: 
server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
 ---
    @@ -161,7 +164,16 @@ public void configure(String configuration) {
       @Override
       public Status replicate(final Path p, final Status status, final 
ReplicationTarget target, final ReplicaSystemHelper helper) {
         final Instance localInstance = HdfsZooInstance.getInstance();
    -    final AccumuloConfiguration localConf = new 
ServerConfigurationFactory(localInstance).getConfiguration();
    +    AccumuloConfiguration instanceConf = new 
ServerConfigurationFactory(localInstance).getConfiguration();
    +
    +    // Overwrite RPC timeout value used by ClientContext with the 
replication timeout value
    +    Map<String,String> confMap = new HashMap<>();
    +    instanceConf.getProperties(confMap, Predicates.<String> alwaysTrue());
    +    confMap.put(Property.GENERAL_RPC_TIMEOUT.getKey(), 
instanceConf.get(Property.REPLICATION_RPC_TIMEOUT));
    --- End diff --
    
    Actually, I'd rather just do that.  Seems like a reasonable API to me and 
the only function using that private method is `getClientNoTimeout`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to