Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/256#discussion_r115585723
  
    --- Diff: 
core/src/main/java/org/apache/accumulo/core/client/rfile/RFileScanner.java ---
    @@ -135,16 +142,41 @@ public long requestCount() {
         }
     
         this.opts = opts;
    -    if (opts.indexCacheSize > 0) {
    -      this.indexCache = new LruBlockCache(opts.indexCacheSize, 
CACHE_BLOCK_SIZE);
    -    } else {
    -      this.indexCache = new NoopCache();
    -    }
     
    -    if (opts.dataCacheSize > 0) {
    -      this.dataCache = new LruBlockCache(opts.dataCacheSize, 
CACHE_BLOCK_SIZE);
    -    } else {
    -      this.dataCache = new NoopCache();
    +    if (opts.indexCacheSize > 0 || opts.dataCacheSize > 0) {
    +      ConfigurationCopy cc = new ConfigurationCopy();
    +      cc.set(Property.TSERV_CACHE_FACTORY_IMPL, 
LruBlockCacheFactory.class.getName());
    +      try {
    +        factory = BlockCacheFactory.getInstance(cc);
    --- End diff --
    
    This will use Accumulo start to load classes.  Currently, Accumulo code 
that loads classes client side avoids using Accumulo start.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to