Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/270#discussion_r122803187
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java
---
@@ -894,12 +894,19 @@ public static void removeBulkLoadEntries(Connector
conn, String tableId, long ti
BatchWriter bw = conn.createBatchWriter(MetadataTable.NAME, new
BatchWriterConfig())) {
mscanner.setRange(new KeyExtent(tableId, null,
null).toMetadataRange());
mscanner.fetchColumnFamily(TabletsSection.BulkFileColumnFamily.NAME);
+ boolean shouldTrace = log.isTraceEnabled();
+ String tidString = Long.toString(tid);
--- End diff --
This is a nice optimization. Could take it a step further and convert the
string to a byte array and compare (using Arrays class) byte arrays in the
loop. This avoids converting each vals byte array to a string in the loop.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
