Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/293#discussion_r134034922
--- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java
---
@@ -416,8 +416,9 @@ public void flushIfNeeded() throws IOException {
}
private boolean isGiantKey(Key k) {
- // consider a key thats more than 3 standard deviations from
previously seen key sizes as giant
- return k.getSize() > keyLenStats.getMean() +
keyLenStats.getStandardDeviation() * 3;
+ double mean = keyLenStats.getMean();
+ double stddev = keyLenStats.getStandardDeviation();
+ return k.getSize() > mean + 3 * Math.max(mean, stddev);
--- End diff --
Could add some comments here about why this logic is used to determine if
key is giant...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
