[ 
https://issues.apache.org/activemq/browse/AMQ-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40056
 ] 

David Sitsky commented on AMQ-1251:
-----------------------------------

Thanks for that Rob, I'll try out the latest code soon.

Following Vadim's advice, I restructured my application to use synchronous 
receives, and setting prefetchSize = 0 prevented the issue from occurring.  
Setting it to a value of 1 or more in my application causes the issues of 
messages not being delivered.

When I get some time soon, I'll update my activemq and let you know if your 
changes have indeed fixed the problems I am seeing for other prefetch sizes.




> Broker stops delivering messages to some consumers
> --------------------------------------------------
>
>                 Key: AMQ-1251
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1251
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 4.1.0
>         Environment: WinXP
>            Reporter: Vadim Pesochinskiy
>            Assignee: Rob Davies
>             Fix For: 5.0.0
>
>         Attachments: TestActiveMQ.java
>
>
> I have around 40 consumers taking messages from a single queue. After awhile 
> 1 or 2 consumers stop receiveing any messages. Going to JMX and stopping 
> corresponding connection causes re-connect and messages are delivered again.
> I reproduced it twice in QA enviroment and now it happened in production. I 
> tried to instrument the code and set the log in debug, but that changed 
> timing and I failed to reproduce it after the changes.
> I suspect that runtime association b/w Queue and Consumer objects is lost on 
> the Broker side. 
> One of the suspects is the empty catch block in the RoundRobinDispatchPolicy 
> (line 64) class. It is possible that the CopyOnWrite array list is messed up 
> and it fails when removed consumer is added back. 
> BTW CopyOnWrite list is good when you mostly read, but not so good when you 
> write for every message delivery and empty catch blocks are bad in any case.
> if (firstMatchingConsumer != null) {
>       // Rotate the consumer list.
>       try {
>                 consumers.remove(firstMatchingConsumer);
>                 consumers.add(firstMatchingConsumer);
>       } catch (Throwable bestEffort) {
>       }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to