Hi Jon

Do you mind add a few lines on the wiki somewhere with building the
source etc. how to enable this checkstyle. As I would like to try to
run it before doing bigger commits to spare willem and others.
But I kinda forget all the maven profiles that is out there.

/Claus Ibsen
Apache Camel Committer
Blog: http://davsclaus.blogspot.com/



On Mon, Dec 1, 2008 at 9:11 PM, Jonathan Anstey <[EMAIL PROTECTED]> wrote:
> Agreed.
>
> I've disabled checkstyle by default. Pass in -Psourcecheck to enable it :)
>
> James Strachan wrote:
>>
>> 2008/12/1 James Strachan <[EMAIL PROTECTED]>:
>>
>>>
>>> 2008/12/1 Claus Ibsen <[EMAIL PROTECTED]>:
>>>
>>>>
>>>> Hi
>>>>
>>>> No me neither. I used to have the CXF checkstyle format that is
>>>> somewhere in the camel code as a .jar file you can import in IDEA.
>>>>
>>>> What I have not is it to be configured with the correct import order
>>>> so I can optimize imports. But the only pita is the auto import
>>>> on-the-fly will insert it at the wrong place
>>>> so you have to optimize it from time to time.
>>>>
>>>> Otherwise I think William is happy with it turned on, as it saves a
>>>> lot of his work to fix and commit code ;)
>>>>
>>>> I am not a maven hog, but I guess there is some parameter you can add
>>>> to skip it. Jon / William?
>>>>
>>>
>>> IMHO if folks using IDEA can't develop code efficiently (i.e. manually
>>> having to frig with the code to get past checkstyle rules) - I'd say
>>> the checkstyle plugin is of limited value anyway - whether its
>>> mandatory or optional.
>>>
>>
>> I'd much rather have lots of folks contributing to Camel - than having
>> folks turning away in frustration at having their IDE put some imports
>> in the wrong order or adding the odd extra space here or there. Having
>> lots of happy contributors far outweighs use of whitespace & imports
>> ordering IMHO!
>>
>>
>
>

Reply via email to