[
https://issues.apache.org/activemq/browse/CAMEL-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48189#action_48189
]
Claus Ibsen commented on CAMEL-1159:
------------------------------------
William nice patch.
I was wondering if the out batch sample using
- in batch size = 1
- out batch size = 10
<aggregate strategyRef="myAggregatorStrategy" batchSize="1" outBatchSize="10">
Why is the in batch at 1? Is it intended. Can it be removed, so you can choose
which batch size you want to use
- IN (number of exchanges) received
- OUT (number of exchanges) to send
So I think a more common use case would be having higher IN batch size than
OUT. If that is the fact I think we should change the sample to reflect this.
There is also a Java DSL sample.
Minor spelling
// out batch is disable, so go ahead and send.
It should be *disabled*
> Check the logic in Aggregator.isBatchCompleted()
> ------------------------------------------------
>
> Key: CAMEL-1159
> URL: https://issues.apache.org/activemq/browse/CAMEL-1159
> Project: Apache Camel
> Issue Type: Task
> Components: camel-core
> Reporter: William Tam
> Assignee: William Tam
> Fix For: 2.0.0
>
> Attachments: CAMEL-1159.patch
>
>
> Understand the logic of this method and also see if the protected method
> getCollection() is really needed (or getCollectionSize() is suffice). The
> reason being supporting the getCollection() method may constraint the
> BatchProcessor class to implement less efficient algorithm.
> {code}
> @Override
> protected boolean isBatchCompleted(int index) {
> if (aggregationCompletedPredicate != null) {
> // TODO: (davsclaus) What is the point with this code? I think
> its wrong
> if (getCollection().size() > 0) {
> return true;
> }
> }
> return super.isBatchCompleted(index);
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
