[
https://issues.apache.org/activemq/browse/AMQ-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48428#action_48428
]
Hiram Chirino commented on AMQ-2045:
------------------------------------
Looks good. Perhaps we should change those consistency checks to assert calls
so that users can avoid doing them in production since they are being done in
synchronized blocks.
> Unbalanced Valve usage in VMTransport.
> --------------------------------------
>
> Key: AMQ-2045
> URL: https://issues.apache.org/activemq/browse/AMQ-2045
> Project: ActiveMQ
> Issue Type: Bug
> Components: Transport
> Affects Versions: 5.3.0
> Reporter: David Jencks
> Assignee: Hiram Chirino
> Fix For: 5.3.0
>
>
> Valve doesn't check that its state is consistent (counters >= 0). There's
> unbalanced increment/decrement calls in VMTransport.oneway:
> enqueueValve.decrement(); //TODO unbalanced??
> (line ~99)
> If I balance this with a preceding enqueValve.increment() I get a deadlock in
> a test when the server tries to send a response message so I assume the
> correct fix is to remove the decrement in this VMTransports valve.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
