[
https://issues.apache.org/activemq/browse/AMQ-2813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Nawrocki updated AMQ-2813:
------------------------------
Attachment: broker_startup_fix.patch
Attached is a patch (generated with svn diff) that fixes it for my use case. I
don't think it will have any unintended consequences for users instantiating a
BrokerService and not using the XBeanBrokerService. If this makes it into
5.4.1 I'd be happy to close this issue.
> BrokerService @PostConstruct invalidates XBeanBrokerService w/ start=false
> --------------------------------------------------------------------------
>
> Key: AMQ-2813
> URL: https://issues.apache.org/activemq/browse/AMQ-2813
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.3.1
> Reporter: Dan Nawrocki
> Assignee: Dejan Bosanac
> Priority: Minor
> Fix For: 5.4.0
>
> Attachments: broker_startup_fix.patch
>
>
> - XBeanBrokerService#afterPropertiesSet() method checks the start flag and is
> annotated as @PostConstruct so it's called at startup
> - BrokerService#start() method has the @PostConstruct annotation as well
> - There is no way for the BrokerService class to check the 'start' flag in
> the XBeanBrokerService subclass.
> - Spring will call BOTH @PostConstruct methods resulting in the broker being
> started regardless of the xbean start flag
> According to Gary Tully:
> That looks like a bug that was introduced in
> http://svn.apache.org/viewvc?rev=908182&view=rev the postConstruct on
> the start method does invalidate the
> XBeanBrokerService#afterPropertiesSet() smarts.
> As discussed in:
> http://old.nabble.com/XBean-%27start%3Dfalse%27-not-working--td29086727.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
