[ 
https://issues.apache.org/jira/browse/AMQ-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986512#action_12986512
 ] 

Peter Hinds edited comment on AMQ-2656 at 1/25/11 12:05 PM:
------------------------------------------------------------

In websphere there are options in 2.ii and 3.i to add what are called 'custom 
properties' but these do not get translated into jndi environment properties 
unfortulately.

In terms of which route to take I would say that the provider url should be 
left intact. To me it would be more intuitive if the name you supply to a jndi 
lookup call determines if an ActiveMQXAConnectionFactory or an 
ActiveMQConnectionFactory is returned as opposed to the provider url used to 
create the InitialContext. I guess setting it in the provider url abstracts it 
away from where it is relevant, which is in the jndi lookup call. As in all 
things though, this is just my opinion - and I'm more than wiling to be 
corrected!

Using the 'XAConnectionFactory' jndi name also has the additional benefit of 
leaving the well recognised url of 'tcp://localhost:61616' untouched as well as 
being tried and tested - thanks to Edan!!



      was (Author: hindsbeans):
    In websphere there are options in 2.ii and 3.i to add what are called 
'custom properties' but these do not get translated into jndi environment 
properties unfortulately.

In terms of which route to take I would say that the provider url should be 
left intact. To me it would be more intuitive if the name you supply to a jndi 
lookup call determines if an ActiveMQXAConnectionFactory or an 
ActiveMQConnectionFactory is returned as opposed to the provider url used to 
create the InitialContext. I guess setting it in the provider url abstracts it 
away from where it is relevant, which is in the jndi lookup call. As in all 
things though, this is just my opinion - and I'm more than wiling to be 
corrected!

Using the 'XAConnectionFactory' jndi name also has the additional benefit of 
leaving the well recognised url of 'tcp://localhost:61616' untouched as ell as 
being tried and tested - thanks to Edan!!


  
> ActiveMQInitialConnectionFactory cannot return an XAConnectionFactory
> ---------------------------------------------------------------------
>
>                 Key: AMQ-2656
>                 URL: https://issues.apache.org/jira/browse/AMQ-2656
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: JMS client
>    Affects Versions: 5.3.0
>            Reporter: Edan idzerda
>            Assignee: Gary Tully
>             Fix For: 5.4.0
>
>         Attachments: ActiveMQInitialContextFactory.java, 
> ActiveMQInitialContextFactory.java
>
>
> ActiveMQInitialContextFactory cannot resolve the name "XAConnectionFactory"  
> a la:
> INFO: JNDI API lookup failed: javax.naming.NameNotFoundException: 
> XAConnectionFactory
> This prevents using the builtin JNDI service in an XA transaction context.  
> I've created a simple patch to workaround this and discussed it on the 
> mailing list:  
> http://old.nabble.com/ActiveMQ%27s-JNDI-does-not-resolve-XAConnectionFactory-td27936255.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to