Sounds good. The re-write can probably wait for 1.5.1 as long as you feel that the area of code it is testing is solid. It fails every time for me. I don't have the time right now to really dig into it to figure out the timings. Sorry. Since this is a timeout test, crafting the timings is important.
On Tue, Feb 15, 2011 at 11:37 AM, Timothy Bish <[email protected]> wrote: > On Tue, 2011-02-15 at 10:45 -0800, Jim Gomes wrote: > > The InactivityMonitorTest.TestWriteMessageFail() unit test in > > Apache.NMS.ActiveMQ.Test.dll fails when I run the unit tests. Can you > > confirm that this fails for you as well? I'm running on .NET 4.0, but > don't > > know yet if that makes any difference. It would be a good idea to > > investigate this unit test to see if it is a show stopper or not. There > is > > another failing unit test, but I don't consider that one to be a show > > stopper. > > I just ran the test a few times, it does occasionally fail, looking at > the code I think its just timing issues in the test. This is probably a > test we should rewrite to try and remove as many of the sleep calls and > make the test more predictable. > > > > > > On Mon, Feb 14, 2011 at 7:00 AM, Timothy Bish <[email protected]> > wrote: > > > > > Hello > > > > > > This is a call for a vote on the release of Apache.NMS.ActiveMQ v1.5.0. > > > > > > New in this release: > > > > > > * New startupMaxReconnectAttempts option in the failover transport. > > > * Fixed a memory leak in the Inactivity Monitoring code. > > > * Fixed a bug that could cause the Failover to not work. > > > * Fixed a bug that caused SSL Certs to not be loaded in some cases. > > > * Several other bugfixes for issues found since v1.4.0 was released. > > > * Added support for participation in .NET Distributed Transactions > > > (MSDTC). > > > * Added .NET 4.0 build. > > > * Many more fixes and internal improvements. > > > > > > The binaries and source bundles for the Release Candidate can be found > > > here: > > > <http://people.apache.org/~tabish/nms-1.5.0/> > > > > > > The Wiki Page for this release is here: > > > <http://activemq.apache.org/nms/apachenmsactivemq-v150.html> > > > > > > The list of issues resolved is here: > > > < > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311201&version=12315640 > > > > > > > > > > Please cast your votes (the vote will be open for 72 hrs): > > > > > > [ ] +1 Release the source as Apache NMS.ActiveMQ v1.5.0 > > > [ ] -1 Veto the release (provide specific comments) > > > > > > Here's my +1 > > > > > > Regards > > > > > > > > > -- > > > Tim Bish > > > ------------ > > > FuseSource > > > Email: [email protected] > > > Web: http://fusesource.com > > > Twitter: tabish121 > > > Blog: http://timbish.blogspot.com/ > > > > > > > > > > > >
