[ 
https://issues.apache.org/jira/browse/AMQ-3209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004299#comment-13004299
 ] 

Timothy Bish commented on AMQ-3209:
-----------------------------------

Looking at your patch I think it probably would suffice to check if the "?" 
lies beyond the last parenthesis instead of searching for the matching set, 
what do you think?

Also the assert statements in the unit tests have the arguments backwards, the 
expected result should be first, otherwise the error message is a bit 
confusing.  

> URISupport.createURIWithQuery() fails on some composite uris.
> -------------------------------------------------------------
>
>                 Key: AMQ-3209
>                 URL: https://issues.apache.org/jira/browse/AMQ-3209
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.5.0
>            Reporter: Aja Walker
>            Priority: Minor
>              Labels: util
>         Attachments: URISupport.patch
>
>
> URISupport.createURIWithQuery() fails on composite URIs that have an inner 
> query but not an outer query, e.g.:
> outerscheme:(innerscheme:innerssp?innerquery=0)
> The failure is due to the method not taking into account this possibility and 
> assuming the query consists of everything  after the last question mark.  The 
> attached patch adds a test case in org.apache.activemq.util.URISupportTest 
> that demonstrates the problem, and also modifies 
> URISupport.createURIWithQuery() with a suggested fix for the problem.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to