[ 
https://issues.apache.org/jira/browse/AMQ-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128410#comment-13128410
 ] 

Timothy Bish commented on AMQ-3500:
-----------------------------------

After letting the tests run I realized this fix was a bit to aggressive, it 
should only check that all the params inside the domain of producer or consumer 
are applied.  Its not uncommon for a single destination with producer and 
consumer options to be used to create both.  
                
> Setting destination options should validate against typos
> ---------------------------------------------------------
>
>                 Key: AMQ-3500
>                 URL: https://issues.apache.org/jira/browse/AMQ-3500
>             Project: ActiveMQ
>          Issue Type: Improvement
>    Affects Versions: 5.5.0
>            Reporter: Claus Ibsen
>            Assignee: Timothy Bish
>            Priority: Minor
>             Fix For: 5.6.0
>
>         Attachments: AMQ-3500.patch
>
>
> I think the logic does not validate that all the destination option was 
> succesfully configured.
> http://activemq.apache.org/destination-options.html
> So if you make a typo, AMQ may continue as normal.
> We should add logic like in Camel, where we check the Map is zero after the 
> introspection logic have set the options.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to