[ 
https://issues.apache.org/jira/browse/AMQ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131493#comment-13131493
 ] 

Joe Luo commented on AMQ-3541:
------------------------------

The patch will only address scenario where the message is moved to DLQ queue 
because it is expired. It does not address another scenario where the message 
is moved to DLQ queue because it can not be dispatched (followed by multiple 
retry failures). As the message will not have "originalExpiration" property 
under the second scenario. Therefore the TimestampingBrokerPlugin will still 
recaculate and reset expiration and timestamp properties on the message even 
though the option "processExpiredMessages" is set to false.

I guess it might be better to have broker to be smart enough to recognize a 
dead letter queue destination then decide not to recaculate and reset timestamp 
and expiration properties. It might require pulling out 
individualDeadLetterStrategy to caculate name of DLQ queue.
                
> TimeStampingBrokerPlugin
> ------------------------
>
>                 Key: AMQ-3541
>                 URL: https://issues.apache.org/jira/browse/AMQ-3541
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.5.0
>            Reporter: Matt Pavlovich
>            Priority: Minor
>         Attachments: TimeStampingBrokerPlugin.java, 
> TimeStampingBrokerPlugin.java.patch
>
>
> This patch adds support for not setting an expiration on messages that have 
> already been expired once before when using the TimeStampingBrokerPlugin.  
> This helps deal with messages when they are sent to a DLQ, and you don't want 
> them to expire.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to