[
https://issues.apache.org/jira/browse/AMQ-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158526#comment-13158526
]
William commented on AMQ-3454:
------------------------------
Hi guys,
It's great you made improvement about performance by removing this unnecessary
copy and thank your for taking into account my comment.
Do you plan to make a patch for 5.5.1 ? I'd like to have something proper in
order to use it production. This gain of performance can really help me...
Or perhaps in 5.6.0, will it come out soon ?
Futhermore, in my understanding of getDestinationMap method, it is used to
determine the presence of a destination and BrokerRegion class still makes a
copy of queue's map and topic's map ? Tell me if I am wrong....
So, if I'm right about the hypothesis, can't you improve the performance again
by adding a new method destinationExists(String destinationName) that just
makes a containsKey in the hashmap. Thus we can also remove the copy in all the
use cases in which you try to find out if a destination exists or not.
In any case, even a get() in multiple hashmap is better than a copy, specially
when the hashmap is big.
Thanks.
> Contention on a mutex during a stress when using SimpleAuthenticationPlugin
> ---------------------------------------------------------------------------
>
> Key: AMQ-3454
> URL: https://issues.apache.org/jira/browse/AMQ-3454
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.5.0
> Reporter: William
> Assignee: Gary Tully
> Priority: Critical
> Fix For: 5.6.0
>
> Attachments: RWLockDestinations.txt, amq-config.zip, amq-dump
>
>
> I am testing ActiveMQ 5.5 with my own stress test. I tried to implement a
> stress test that use jms ressource in the same fashion that my application
> would do.
> For that, I used jms template (from Spring) and a pooled connection factory
> (as recommended). I run a fixed number of thread that plublish on fixed
> number of topics. Each thread pick up a topic and enter a loop that will send
> a message on the choosen topic.
> The issue is reproductible with SimpleAuthenticationPlugin active.
> Configuration of the test :
> * 100 topics
> * more than one thread per topic (actually 1500 producer threads)
> Common connection properties :
> * alwaysSessionAsync=false
> * dispatchAsync=false
> * optimizeAcknowledge=true
> *
> socketBufferSize=131072&trace=true&wireFormat.cacheSize=2048&wireFormat.tcpNoDelayEnabled=true&wireFormat.tightEncodingEnabled=true&keepAlive=true&soTimeout=10000&connectionTimeout=10000\
> Producers :
> * Message are not persistent
> * There is no transaction
> * Message expiration time is 30s
> * Unsing JMS template singleton with a PooledConnectionFactory
> * 3 JVM running
> * connection options alwaysSyncSend=true,copyMessageOnSend=false
> Consumers :
> * just listening to each topic with a SimpleMessageListenerContainer and
> count messages received
> * 3 JVM running
> In attachment, you will find activemq config file and thread dumps. I can
> attach the producer/consumers code if you need it but I think you have your
> own tests.
> This Jira is critical for me because security is mandatory for our use.
> If you need more information, please ask.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
