[ 
https://issues.apache.org/jira/browse/AMQ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165420#comment-13165420
 ] 

Claudio Corsi commented on AMQ-3623:
------------------------------------

I looked at the patch and I just noticed that the appender is added to the 
logging system but it is not removed when the test has completed.  

Since the appender references the test case then the test case instance will 
never be reclaimed until the logging system is removed and that is when the 
application ends.  

Would you consider adding the code that remove the added appender when the test 
has completed.
                
> Add DefaultTestAppender utility abstract class
> ----------------------------------------------
>
>                 Key: AMQ-3623
>                 URL: https://issues.apache.org/jira/browse/AMQ-3623
>             Project: ActiveMQ
>          Issue Type: New Feature
>          Components: Test Cases
>    Affects Versions: 5.5.1
>            Reporter: Stan Lewis
>            Assignee: Gary Tully
>            Priority: Minor
>             Fix For: 5.6.0
>
>         Attachments: 
> 0001-Add-DefaultTestAppender-and-modify-existing-tests-to.patch
>
>
> Couple tests keep an eye on the logging for specific failures, be good to 
> have a common approach to this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to