[ 
https://issues.apache.org/jira/browse/AMQ-3457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189122#comment-13189122
 ] 

Timothy Bish commented on AMQ-3457:
-----------------------------------

ActiveMQConnection keeps track of the temp destinations, and the patch causes 
the PooledConnection to ask the connection to deletes the temp destinations it 
created once the PooledConnection is closed, so no need to deplicate that logic 
in the PooledConnection.

If you are still seeing an issue then a JUnit test case to demonstrate the 
problem would be appropriate.
                
> temp destinations should only be deleted once all users of a pooled 
> connection call close
> -----------------------------------------------------------------------------------------
>
>                 Key: AMQ-3457
>                 URL: https://issues.apache.org/jira/browse/AMQ-3457
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.x
>         Environment: 5.6-SNAPSHOT
>            Reporter: Jonathan Anstey
>            Assignee: Jonathan Anstey
>             Fix For: 5.6.0
>
>         Attachments: amqpool.diff
>
>
> AMQ-2349 added some code to clean up temp destinations once close() is called 
> on a pooled connection. This caused pretty much all the JMS request-reply 
> tests to fail in Camel with "javax.jms.InvalidDestinationException: Cannot 
> publish to a deleted Destination" :) 
> The problem is that with a pooled connection, multiple users can be using a 
> Connection at the same time (a reference count is kept of how many there are) 
> so if once calls close() the temp destinations of several others could be 
> deleted while they are still using them. I think the correct behavior would 
> be to only delete the temp destinations when all connection users call 
> close() (i.e. when the reference count becomes zero).
> Attaching a proposed fix for this shortly for review.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to