[ 
https://issues.apache.org/jira/browse/AMQ-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothy Bish resolved AMQ-3709.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 5.6.0

patch applied, thanks.
                
> Patch to fix invalid XHTML in web-console's 404 and 500 pages
> -------------------------------------------------------------
>
>                 Key: AMQ-3709
>                 URL: https://issues.apache.org/jira/browse/AMQ-3709
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: activemq-camel
>         Environment: This is really N/A for this issue, but we are on Linux 
> (RHEL6) VMs.
>            Reporter: Adrian Michael Nida
>              Labels: patch, webconsole
>             Fix For: 5.6.0
>
>         Attachments: activemq.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> We created a monitor that utilizes calls to the web-console to determine 
> stuck messages.  Occasionally, requests come back 404 (because the message 
> disappears between calls) and the monitor dies because the XHTML for that 
> page is invalid.  This patch makes the 404 and 500 pages valid in the eyes of 
> the w3c markup validation service.
> Note: I'm placing the patch here because I do not see a place to upload it on 
> this form.  If it appears later, I will attached.
> Index: activemq-web-console/src/main/webapp/500.html
> ===================================================================
> --- activemq-web-console/src/main/webapp/500.html     (revision 1242141)
> +++ activemq-web-console/src/main/webapp/500.html     (working copy)
> @@ -22,8 +22,7 @@
>   
>  <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" 
> "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";> 
>   
> -<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" 
> "http://www.w3.org/TR/html4/loose.dtd";> 
> -<html> 
> +<html xmlns='http://www.w3.org/1999/xhtml'> 
>  <head> 
>      <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" 
> /> 
>      <title>Apache ActiveMQ</title> 
> @@ -67,7 +66,7 @@
>                      <div class="top_red_bar"> 
>                          <div id="site-breadcrumbs"> 
>                          </div> 
> -                        <div id="site-quicklinks"><P> 
> +                        <div id="site-quicklinks"><p> 
>                              <a href="http://activemq.apache.org/support.html";
>                                 title="Get help and support using Apache 
> ActiveMQ">Support</a></p> 
>                          </div> 
> @@ -93,7 +92,7 @@
>                                      <div class="navigation"> 
>                                          <div class="navigation_top"> 
>                                              <div class="navigation_bottom"> 
> -                                                <H3>Useful Links</H3> 
> +                                                <h3>Useful Links</h3> 
>   
>                                                  <ul class="alternate" 
> type="square"> 
>                                                      <li><a 
> href="http://activemq.apache.org/";
> Index: activemq-web-console/src/main/webapp/404.html
> ===================================================================
> --- activemq-web-console/src/main/webapp/404.html     (revision 1242141)
> +++ activemq-web-console/src/main/webapp/404.html     (working copy)
> @@ -22,8 +22,7 @@
>   
>  <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" 
> "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";> 
>   
> -<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" 
> "http://www.w3.org/TR/html4/loose.dtd";> 
> -<html> 
> +<html xmlns='http://www.w3.org/1999/xhtml'> 
>  <head> 
>      <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" 
> /> 
>      <title>Apache ActiveMQ</title> 
> @@ -67,7 +66,7 @@
>                      <div class="top_red_bar"> 
>                          <div id="site-breadcrumbs"> 
>                          </div> 
> -                        <div id="site-quicklinks"><P> 
> +                        <div id="site-quicklinks"><p> 
>                              <a href="http://activemq.apache.org/support.html";
>                                 title="Get help and support using Apache 
> ActiveMQ">Support</a></p> 
>                          </div> 
> @@ -92,7 +91,7 @@
>                                      <div class="navigation"> 
>                                          <div class="navigation_top"> 
>                                              <div class="navigation_bottom"> 
> -                                                <H3>Useful Links</H3> 
> +                                                <h3>Useful Links</h3> 
>   
>                                                  <ul class="alternate" 
> type="square"> 
>                                                      <li><a 
> href="http://activemq.apache.org/";

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to