[
https://issues.apache.org/jira/browse/AMQ-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295445#comment-13295445
]
Raj Saini edited comment on AMQ-3883 at 6/15/12 4:09 AM:
---------------------------------------------------------
Hello Freeman,
Would it not be better to compare the getName() method of Principal interface?
For example:
public boolean equals(Object o) {
if (this == o) {
return true;
}
if(o instanceof Principal) {
if (((Principal) o).getName().equals(this.getName())) {
return true;
}
}
if (o == null || getClass() != o.getClass()) {
return false;
}
final GroupPrincipal that = (GroupPrincipal)o;
if (!name.equals(that.name)) {
return false;
}
return true;
}
This way, compare will not only work with any other JAAS implementation.
was (Author: rajsaini):
Hello Freeman,
Would it not be better to compare the getName() method of Principal interface?
For example:
{{monospaced}}
public boolean equals(Object o) {
if (this == o) {
return true;
}
if(o instanceof Principal) {
if (((Principal) o).getName().equals(this.getName())) {
return true;
}
}
if (o == null || getClass() != o.getClass()) {
return false;
}
final GroupPrincipal that = (GroupPrincipal)o;
if (!name.equals(that.name)) {
return false;
}
return true;
}
This way, compare will not only work with any other JAAS implementation.
> activemq-jaas authorization doesn't work with Karaf JAAS LoginModule
> --------------------------------------------------------------------
>
> Key: AMQ-3883
> URL: https://issues.apache.org/jira/browse/AMQ-3883
> Project: ActiveMQ
> Issue Type: Bug
> Reporter: Freeman Fang
> Attachments: AMQ-3883.patch
>
>
> currently activemq-jaas can't work with karaf loginModule, the reason comes
> from the compare between
> amq GroupPrincipal and karaf UserPrincipal/RolePrincipal doesn't work
> More details please see[1].
> We have a similar issue in Servicemix NMR[2] and the fix can honor the
> compare between
> amq GroupPrincipal and karaf UserPrincipal/RolePrincipal yet not introduce
> any dependency between activemq-jaas and karaf jaas.
> [1]http://karaf.922171.n3.nabble.com/Karaf-ActiveMQ-authorization-problem-td4024834.html
> [2]https://issues.apache.org/jira/browse/SMX4NMR-283
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
