[ 
https://issues.apache.org/jira/browse/AMQ-4085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527091#comment-13527091
 ] 

SuoNayi commented on AMQ-4085:
------------------------------

Returning the InvalidClientIDException to the client is necessary.
When InvalidClientIDException is thrown by the broker the connection between 
the broker and the client is still established but you can not use that to 
create sessions, consumers or producers.
Now we get a useless connection and it seems like a connectionn leak problem in 
this case.
For failover transport in the client, if the client detects 
InvalidClientIDException and then close the current transport and retry to 
connect to the broker or when the broker detects the InvalidClientIDException 
it just close the connection so that the client will do the reconnection logic.
Not sure it is reasonable or not but seems it will be more transparent to the 
end user.

                
> When InvalidClientIDException the failover transport for client should retry 
> to connection the broker transparently
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-4085
>                 URL: https://issues.apache.org/jira/browse/AMQ-4085
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: activemq-pool, Broker, JMS client
>    Affects Versions: 5.x
>            Reporter: SuoNayi
>            Priority: Minor
>              Labels: InvalidClientIDException, failover
>             Fix For: NEEDS_REVIEWED
>
>
> With the current solution,when using the connection to create session the 
> InvalidClientIDException will be thrown but the underlying failover transport 
> takes no far actions.
> For creating session successfully, you have to recreate a new connection 
> instance(close the old one),this is not good for the shared connection style 
> such as Spring JMS or activemq-pool.
> We would like the transparent reconnect transport insteand of creating new 
> connection.
> I have commented this at https://issues.apache.org/jira/browse/AMQ-3792.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to