[ 
https://issues.apache.org/jira/browse/AMQ-4241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542188#comment-13542188
 ] 

SuoNayi commented on AMQ-4241:
------------------------------

Hi, it's an improvement not issue.
Every flush buffer opertion triggered by write opertion will call the send 
method in the ActiveMQOutputStream
and the call will attach those properties to the underlying message every time.
Supposing there are 10 messages are created to transfer the payload of the 
stream, then the 10 messages both 
have those properties the end user specifies.Additional bandwidth overhead is 
involved obviously.
It's unnecessary to carry those properties by every message.
The first message carries those properties will be ok and ActiveMQInputStream 
can obtain those properties by 
the first incoming message as well.

                
> ActiveMQOutputStream shoud reserve the user property only once
> --------------------------------------------------------------
>
>                 Key: AMQ-4241
>                 URL: https://issues.apache.org/jira/browse/AMQ-4241
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 5.5.1, 5.6.0, 5.7.0
>            Reporter: SuoNayi
>            Priority: Trivial
>              Labels: JMSStream
>             Fix For: 5.8.0
>
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> ActiveMQOutputStream should only reserve the properties from the end user 
> by the first message instead of reserving the properties by every message 
> under the hood.
> While ActiveMQInputStream can obtain those properties by the first incoming 
> message.
> By the way, the exposed call of the receive method to the end user is 
> dangerous because
> the user call on the receive method will cause the data the user received is 
> not the
> whole. The payload of the message that the call returns is lost because it's 
> out of the
> underlying stream.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to