Hi Okay I have move the osgi hook into an osgi sub package. And made the osgi JARs provided and optional.
So Maven end users is not polluted with OSGi. On Sat, Jan 12, 2013 at 9:47 PM, Timothy Bish <[email protected]> wrote: > +1 for moving all OSGi stuff to the designated module. > > On Sat, 2013-01-12 at 10:28 +0100, Claus Ibsen wrote: >> Hi >> >> I am looking into >> https://issues.apache.org/jira/browse/AMQ-4252 >> >> We have 2 hooks classes in org.apache.activemq.hooks package. >> There is a regular Spring, and then another for OSGi. >> >> These classes is not in use in this component. >> I wonder where these hooks are in use? >> >> Though we should move the osgi code into >> org.apache.activemq.hooks.osgi >> >> So its not in the same package, then we can have OSGi is scope=optional. >> Then OSGi does not creep into the maven dependency for non OSGi users. >> >> We do this in Apache Camel. Keep OSGi code in their own packages. >> >> >> >> > > -- > Tim Bish > Sr Software Engineer | RedHat Inc. > [email protected] | www.fusesource.com | www.redhat.com > skype: tabish121 | twitter: @tabish121 > blog: http://timbish.blogspot.com/ > -- Claus Ibsen ----------------- Red Hat, Inc. FuseSource is now part of Red Hat Email: [email protected] Web: http://fusesource.com Twitter: davsclaus Blog: http://davsclaus.com Author of Camel in Action: http://www.manning.com/ibsen
