[ 
https://issues.apache.org/jira/browse/AMQ-4365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757687#comment-13757687
 ] 

Gary Tully commented on AMQ-4365:
---------------------------------

@Farhad, there should be a single broker lock or a single lock at the mKahaDb 
level - having each of the nested kahadb instances use their own lock is broken 
for a few reasons. not least that the instances are created on demand, so a 
slave could see none when it starts.
A single instance of the sharedfilelocker could work (one bean referenced by 
each instance) b/c the file lock is acquired at the jvm level.
But master/slave mKahaDb needs a little bit of love atm. Making MultiKahaDB 
extend LockableServiceSupport or making the Broker extend 
LockableServiceSupport would fix this. The nested kahadb elements would then 
need useLock=false
                
> Allow the Lease Locker to be used with out a JDBCPersistenceAdapter - so it 
> can be a broker lock
> ------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-4365
>                 URL: https://issues.apache.org/jira/browse/AMQ-4365
>             Project: ActiveMQ
>          Issue Type: Improvement
>    Affects Versions: 5.8.0
>            Reporter: Gary Tully
>            Assignee: Gary Tully
>             Fix For: 5.9.0
>
>
> The locker interface needs another configure option to provide a broker 
> service, or needs to be brokerService aware so that a locker can get identity 
> and access to the io exception handlers.
> The lease database locker is dependent on the jdbc pa to get statements and 
> data source. It should be possible to configure these independently such that 
> it can be used standalone as a broker lock. So setters for each.
> This will help sort out some of the dependencies between broker and lock 
> implementations. also making it possible to use a lease lock with kahadb for 
> example.
> some context: 
> http://mail-archives.apache.org/mod_mbox/activemq-users/201303.mbox/%3ccaj5znhuruz+aewsaabajtwbbpkwn06ryyyt6nqsdg_su7vm...@mail.gmail.com%3E

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to