[
https://issues.apache.org/jira/browse/AMQ-5306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084749#comment-14084749
]
ASF GitHub Bot commented on AMQ-5306:
-------------------------------------
GitHub user jkorab opened a pull request:
https://github.com/apache/activemq/pull/39
Fix for AMQ-5306
Cleaned up logic around the use of comma separated destinations,
sysTest.totalDests and producer.destComposite. The logic is as follows:
Given -Dproducer.destName=foo:
default (-DsysTest.totalDests=1)
* publishes to 1 destination - foo
-DsysTest.totalDests=2
* publishes to 2 destinations - foo.0, foo.1
Given -Dproducer.destName=foo,cheese:
default (-Dproducer.destComposite=false -DsysTest.totalDests=1)
* publishes to 2 destinations - foo and cheese
(-Dproducer.destComposite=false) -DsysTest.totalDests=2
* publishes to 4 destinations - foo.0, foo.1 and cheese.0, cheese.1
-Dproducer.destComposite=true (-DsysTest.totalDests=1)
* publishes to 1 composite destination - "foo,cheese"
-Dproducer.destComposite=true -DsysTest.totalDests=2
* publishes to 1 composite destination - "foo.0,foo.1,cheese.0,cheese.1"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkorab/activemq trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit 1702265c73296955a1c2baf72d405a805efe8cd9
Author: jkorab <[email protected]>
Date: 2014-07-31T16:15:03Z
Modified so that single-destination tests do not append a numerical prefix.
commit 42ac31d04ddddfc23bdc6718ae6d80e40dc4f772
Author: jkorab <[email protected]>
Date: 2014-07-31T16:37:34Z
Unified the logic for appending numerical prefixes between normal one-off
destinations and composite destinations. Fixed composite destination
construction logic that created 2 destinations when sysTest.totalDests was 1 or
2.
commit 1b69f1c8bc020261b498ba0867b4abf0c3b33b3c
Author: jkorab <[email protected]>
Date: 2014-08-04T10:53:36Z
Merge remote-tracking branch 'upstream/trunk' into trunk
commit a6c8c15f2ae666725b846e2008d7a80dd9cfbe3e
Author: jkorab <[email protected]>
Date: 2014-08-04T14:09:55Z
Fix for AMQ-5306. Cleaned up logic around the creation of multiple and
composite destinations. Added tests.
commit 4e04d434f87ef4389e316c37d0a74e847e71c1d8
Author: jkorab <[email protected]>
Date: 2014-08-04T14:55:29Z
AMQ-5306 Added logic for use case where 2 comma separated dests are named,
and composite = true
----
> Composite destination creation in perf test always builds topics
> ----------------------------------------------------------------
>
> Key: AMQ-5306
> URL: https://issues.apache.org/jira/browse/AMQ-5306
> Project: ActiveMQ
> Issue Type: Bug
> Components: Performance Test
> Affects Versions: 5.10.0
> Reporter: Jakub Korab
> Priority: Minor
>
> When the performance test is triggered via the following flags, the resulting
> test run sends messages to two topics, as opposed to queues:
> mvn activemq-perf:producer -Dproducer.composite=true -DsysTest.totalDests=2
> -Dproducer.destName=queue://foo
> Messages will be sent to topic://foo.0 and topic://foo.1.
> Pull request incoming.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
