[
https://issues.apache.org/jira/browse/AMQ-5378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dejan Bosanac updated AMQ-5378:
-------------------------------
Attachment: AMQ-5378.patch
Hi Marc,
there's still problem with the proposed solution on osx. Also, I think we're
adding more complexity to the already complex script, which already gave us
problems in the past (as it's not easy to test it properly on all platforms).
I'd like to propose a simpler solution that should still give us the desired
results. It's presented in the attached patch (AMQ-5378.patch).
The new file is added in the bin directory called "env" which contains default
configuration. With this we have a simple file where users can tune jvm and
other runtime options. This file is added to the list of files configuration
files and will be executed by default. Setting up a global configuration is
then just a matter of copying this file to the users folder or /etc.
With this we simplify the main shell script and get the desired functionality
without touching the other logic which has been stable for a while now.
Also, we can maybe remove "setup" operation as it's just a matter of copying
this script to the appropriate place. I haven't touch setup yet, just wanted to
discuss general principle first.
What do you think of this approach?
> Initscript refactoring: setup function seems to be broken, removal of
> uneccessary files
> ---------------------------------------------------------------------------------------
>
> Key: AMQ-5378
> URL: https://issues.apache.org/jira/browse/AMQ-5378
> Project: ActiveMQ
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 5.10.0
> Environment: Linux/Unix
> Reporter: Marc Schöchlin
> Labels: assemblies
> Fix For: 5.11.0
>
> Attachments: AMQ-5378.patch
>
>
> The current initscript seems to be broken.
> I submitted the current unix init script (see AMQ-2453) - the original script
> seems to be modified in a way which breaks the "setup" function
> If you call "./activemq setup ~/.activemq" you get a really messy configfile.
> The current distribution also contains lots of files of the java service
> wrapper which are not needed anymore.
> I created the following patch/pull request:
> https://github.com/apache/activemq/pull/46
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
