Yes. With that one out I think the release would be fine On Dec 24, 2014 3:51 PM, "Hadrian Zbarcea" <[email protected]> wrote:
> Hi Tim, > > I missed your comment, sorry about that. I will remove that patch and redo > the release. Is that your only objection? > > Cheers, > Hadrian > > > On 12/24/2014 03:22 PM, Timothy Bish wrote: > >> -1 >> >> this still contains the code merged in for AMQ-3758 which is not >> appropriate for a point release as it is a complete rewrite of the >> scheduler store which requires a totally new store version. While the >> code >> will attempt to upgrade older versions to the new one this has not seen >> enough real world testing to consider it stable for a point release even >> if >> that were acceptable which it is not. A 5.10.1 release should only >> contain >> bug fixes that would improve the stability of a running 5.10 installation, >> larger changes like this should be held for the coming 5.11 release >> >> I have previously minus one'd the commit here: >> >> http://activemq.2283324.n4.nabble.com/Re-16-16-activemq- >> git-commit-https-issues-apache-org-jira-browse-AMQ-3758-td4688957.html >> >> And commented on the issue as well. >> >> https://issues.apache.org/jira/browse/AMQ-3758 >> >> >> On Tue, Dec 23, 2014 at 9:24 PM, Hadrian Zbarcea <[email protected]> >> wrote: >> >> The release candidate for the activemq 5.10.1 release is now built and >>> ready for a vote. This release comes with 33 bug fixes. >>> >>> >>> The list of resolved issues is here: >>> https://issues.apache.org/jira/issues/?jql=fixVersion% >>> 20%3D%205.10.1%20AND%20project%20%3D%20AMQ >>> >>> You can get binary distributions here: >>> https://repository.apache.org/content/repositories/ >>> orgapacheactivemq-1008/org/apache/activemq/apache-activemq/5.10.1/ >>> >>> Source archives are here: >>> https://repository.apache.org/content/repositories/ >>> orgapacheactivemq-1008/org/apache/activemq/activemq-parent/5.10.1/ >>> >>> Maven2 repository is here: >>> https://repository.apache.org/content/repositories/ >>> orgapacheactivemq-1008/ >>> >>> Source tag: >>> https://git-wip-us.apache.org/repos/asf?p=activemq.git;a=commit;h= >>> af6ce5c93414c097ef5166e457598184b6c3af04 >>> >>> >>> Please test this release and cast your vote. >>> >>> [ ] +1 Release the binary as Apache ActiveMQ 5.10.1 >>> [ ] -1 Veto the release (provide specific comments) >>> >>> >>> Cheers, >>> Hadrian >>> >>> >>> >> >
