[ https://issues.apache.org/jira/browse/AMQ-4929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317453#comment-14317453 ]
Zak Hassan edited comment on AMQ-4929 at 2/12/15 3:08 AM: ---------------------------------------------------------- Thank you. I'll rollback and send up a more complete patch. I just was wondering if I should also remove line 2332 in BrokerService.java (Link provided below). There is mention of transactionbroker being disabled by default in the comment section and I'm not sure but I wanted to know if its safe to remove this line BrokerService.java#L2332 ? https://github.com/zmhassan/activemq/blob/trunk/activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java#L2332 was (Author: zmhassan): Thank you for reviewing. I'll rollback and send up a more complete patch. I just was wondering if I should also remove line 2332 in BrokerService.java (Link provided below). There is mention of transactionbroker being disabled by default in the comment section and I'm not sure but I wanted to know if its safe to remove this line BrokerService.java#L2332 ? https://github.com/zmhassan/activemq/blob/trunk/activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java#L2332 > remove old and unused > org.apache.activemq.broker.BrokerService#setSupportFailOver > --------------------------------------------------------------------------------- > > Key: AMQ-4929 > URL: https://issues.apache.org/jira/browse/AMQ-4929 > Project: ActiveMQ > Issue Type: Bug > Components: Broker > Affects Versions: 5.9.0 > Reporter: Gary Tully > Fix For: 5.12.0 > > > there is a bunch of duplicate detection in transactionbroker that is disabled > by default and not tested that duplicates work done elsewhere - store and > producerAutit. It should be removed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)