[
https://issues.apache.org/jira/browse/ACTIVEMQ6-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334818#comment-14334818
]
ASF GitHub Bot commented on ACTIVEMQ6-82:
-----------------------------------------
GitHub user mtaylor opened a pull request:
https://github.com/apache/activemq-6/pull/109
ACTIVEMQ6-82 activemq.conf file for runtime opts
Linux support only. Allows users to define java args and a number of other
runtime configuration parameters outside of the run scripts. This will
be followed up with support for cmd.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtaylor/activemq-6 activemq_conf
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-6/pull/109.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #109
----
commit beecf0de0751316c68f93b64fe35d99b962e2aa5
Author: Martyn Taylor <[email protected]>
Date: 2015-02-24T12:08:08Z
ACTIVEMQ6-82 activemq.conf file for runtime opts
Linux support only. Allows users to define java args and a number of other
runtime configuration parameters outside of the run scripts. This will
be followed up with support for cmd.
----
> start script limitations
> ------------------------
>
> Key: ACTIVEMQ6-82
> URL: https://issues.apache.org/jira/browse/ACTIVEMQ6-82
> Project: Apache ActiveMQ 6
> Issue Type: Bug
> Environment: UNIX
> Reporter: Daniel Pocock
> Assignee: Martyn Taylor
>
> This issue concerns the start script:
> ./distribution/activemq/src/main/resources/bin/activemq
> There are various issues with JAVA_ARGS at the bottom:
> a) memory parameters are hard-coded in the script and can't be overridden
> without modifying the script
> b) data.dir is hardcoded in the script and can't be overridden without
> modifying the script
> Problem (a) was also present in HornetQ while problem (b) was not there.
> With HornetQ 2.3, it was possible to override the data.dir and also add other
> properties or JMXetric to the JVM command line by setting the CLUSTER_PROPS
> variable in a local wrapper script. However, setting heap parameters in
> CLUSTER_PROPS was ineffective because the HornetQ run.sh would then set them
> to other values later on the command line.
> JBoss / Wildfly seems to do a better job of splitting the logic and
> configuration, they have a script called bin/standalone.sh that contains the
> logic and a separate file, bin/standalone.conf that can be customized with
> environment variables. I think this would be a good model for ActiveMQ 6 to
> follow. Is there already any discussion about refactoring the script?
> This is important for various reasons:
> - people deploying the broker in production environments don't like to modify
> the scripts supplied by a vendor, they usually prefer to have a configuration
> file of their own
> - when upgrading, it is an extra hassle to merge changes into the scripts if
> they have been modified locally
> - some people may want to run multiple instances using the same installation
> directory, same scripts and just using different data and log directories
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
